Improve error messages when accepting connections with errno/errstr #267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset improves the error messages for failed incoming connections to include the appropriate errno/errstr. Reporting the errstr works on all supported platforms, the errno is only available when
ext-sockets
is available. Whereas it would previously report a generic "Error accepting new connection" error, it will now report the actual underlying error condition, such as this:Builds on top of #266, #265, #171, reactphp/dns#171, reactphp/dns#172 and others
Together with #244 this is a prerequisite for #164