Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages when accepting connections with errno/errstr #267

Merged
merged 2 commits into from
Aug 13, 2021

Conversation

clue
Copy link
Member

@clue clue commented Aug 13, 2021

This changeset improves the error messages for failed incoming connections to include the appropriate errno/errstr. Reporting the errstr works on all supported platforms, the errno is only available when ext-sockets is available. Whereas it would previously report a generic "Error accepting new connection" error, it will now report the actual underlying error condition, such as this:

-Error accepting new connection
+Failed to accept new connection: Connection timed out

Builds on top of #266, #265, #171, reactphp/dns#171, reactphp/dns#172 and others
Together with #244 this is a prerequisite for #164

@clue clue added this to the v1.10.0 milestone Aug 13, 2021
@clue clue requested a review from WyriHaximus August 13, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants